Re: [Intel-gfx] [PATCH v2 03/13] drm/i915: Introduce crtc_state->update_planes bitmask

2018-11-21 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 03:14:14PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Keep track which planes need updating during the commit. For now this > > is just (was_visible || is_visible) but I'll have need to update

Re: [Intel-gfx] [PATCH v2 03/13] drm/i915: Introduce crtc_state->update_planes bitmask

2018-11-19 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:19PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Keep track which planes need updating during the commit. For now this > is just (was_visible || is_visible) but I'll have need to update I still think it would be a good idea to mention was_slave ||

[Intel-gfx] [PATCH v2 03/13] drm/i915: Introduce crtc_state->update_planes bitmask

2018-11-14 Thread Ville Syrjala
From: Ville Syrjälä Keep track which planes need updating during the commit. For now this is just (was_visible || is_visible) but I'll have need to update invisible planes later on for skl plane ddbs and for pre-skl pipe gamma/csc control (which lives in the primary plane control register).