Re: [Intel-gfx] [PATCH v2 07/16] drm/i915: Add vblank based delayed watermark update mechanism

2014-06-09 Thread Ville Syrjälä
On Wed, Jun 04, 2014 at 06:10:44PM +0200, Daniel Vetter wrote: On Wed, Jun 04, 2014 at 11:01:01AM -0300, Paulo Zanoni wrote: This function is only called at init/resume. It populates the software state with something that matches the current hardware state. I guess a comment explaning

Re: [Intel-gfx] [PATCH v2 07/16] drm/i915: Add vblank based delayed watermark update mechanism

2014-06-04 Thread Paulo Zanoni
2014-06-03 16:32 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Tue, Jun 03, 2014 at 03:50:12PM -0300, Paulo Zanoni wrote: 2014-05-22 11:48 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Add a mechanism by which you can queue up

Re: [Intel-gfx] [PATCH v2 07/16] drm/i915: Add vblank based delayed watermark update mechanism

2014-06-04 Thread Daniel Vetter
On Wed, Jun 04, 2014 at 11:01:01AM -0300, Paulo Zanoni wrote: This function is only called at init/resume. It populates the software state with something that matches the current hardware state. I guess a comment explaning the purpose of the function is the best we can do here, or do you

Re: [Intel-gfx] [PATCH v2 07/16] drm/i915: Add vblank based delayed watermark update mechanism

2014-06-03 Thread Paulo Zanoni
2014-05-22 11:48 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Add a mechanism by which you can queue up watermark update to happen after the vblank counter has reached a certain value. The vblank interrupt handler will schedule a work which will

Re: [Intel-gfx] [PATCH v2 07/16] drm/i915: Add vblank based delayed watermark update mechanism

2014-06-03 Thread Ville Syrjälä
On Tue, Jun 03, 2014 at 03:50:12PM -0300, Paulo Zanoni wrote: 2014-05-22 11:48 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Add a mechanism by which you can queue up watermark update to happen after the vblank counter has reached a certain

[Intel-gfx] [PATCH v2 07/16] drm/i915: Add vblank based delayed watermark update mechanism

2014-05-22 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Add a mechanism by which you can queue up watermark update to happen after the vblank counter has reached a certain value. The vblank interrupt handler will schedule a work which will do the actual watermark programming in process context. v2: