Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-10 Thread Ville Syrjälä
On Tue, Mar 10, 2015 at 11:26:29AM +0100, Daniel Vetter wrote: > On Thu, Mar 05, 2015 at 09:19:49PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Assuming the PND deadline mechanism works reasonably we should do > > memory requests as early as possible so that PND ha

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-10 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 09:19:49PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Assuming the PND deadline mechanism works reasonably we should do > memory requests as early as possible so that PND has schedule the > requests more intelligently. Currently we're still calcu

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-06 Thread Jesse Barnes
On 03/06/2015 10:14 AM, Ville Syrjälä wrote: > On Fri, Mar 06, 2015 at 09:31:20AM -0800, Jesse Barnes wrote: >> On 03/05/2015 11:19 AM, ville.syrj...@linux.intel.com wrote: >>> From: Ville Syrjälä >> I wonder if we should be warning if the wm values we end up with exceed >> the mask size (the fact

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-06 Thread Ville Syrjälä
On Fri, Mar 06, 2015 at 09:31:20AM -0800, Jesse Barnes wrote: > On 03/05/2015 11:19 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Assuming the PND deadline mechanism works reasonably we should do > > memory requests as early as possible so that PND has schedule the > >

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-06 Thread Daniel Vetter
On Fri, Mar 06, 2015 at 09:31:20AM -0800, Jesse Barnes wrote: > I wonder if we should be warning if the wm values we end up with exceed > the mask size (the fact that you write them with a shift and mask made > me think of it), but that could be a follow on, or even put into the > calc code instead

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-06 Thread Jesse Barnes
On 03/05/2015 11:19 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Assuming the PND deadline mechanism works reasonably we should do > memory requests as early as possible so that PND has schedule the > requests more intelligently. Currently we're still calculating > the water

[Intel-gfx] [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

2015-03-05 Thread ville . syrjala
From: Ville Syrjälä Assuming the PND deadline mechanism works reasonably we should do memory requests as early as possible so that PND has schedule the requests more intelligently. Currently we're still calculating the watermarks as if VLV/CHV are identical to g4x, which isn't the case. The curr