Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Rodrigo Vivi
On Wed, Jul 18, 2018 at 02:30:18PM -0700, Dhinakaran Pandiyan wrote: > On Wed, 2018-07-18 at 13:31 -0700, Manasi Navare wrote: > > On Wed, Jul 18, 2018 at 01:34:12PM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Wed, 2018-07-18 at 10:45 -0700, Manasi Navare wrote: > > > > > > > > On Wed, Jul

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Dhinakaran Pandiyan
On Wed, 2018-07-18 at 13:31 -0700, Manasi Navare wrote: > On Wed, Jul 18, 2018 at 01:34:12PM -0700, Dhinakaran Pandiyan wrote: > > > > On Wed, 2018-07-18 at 10:45 -0700, Manasi Navare wrote: > > > > > > On Wed, Jul 18, 2018 at 10:19:42AM -0700, Dhinakaran Pandiyan > > > wrote: > > > > > > > >

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Nathan Ciobanu
On Wed, Jul 18, 2018 at 10:19:42AM -0700, Dhinakaran Pandiyan wrote: > The short pulse handler checks if channel equalization is okay and > goes onto retrain a link if there are active MST links. This retraining > path is not meant for new MST connections, but due to a bug elsewhere, if >

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Manasi Navare
On Wed, Jul 18, 2018 at 01:34:12PM -0700, Dhinakaran Pandiyan wrote: > On Wed, 2018-07-18 at 10:45 -0700, Manasi Navare wrote: > > On Wed, Jul 18, 2018 at 10:19:42AM -0700, Dhinakaran Pandiyan wrote: > > > > > > The short pulse handler checks if channel equalization is okay and > > > goes onto

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Dhinakaran Pandiyan
On Wed, 2018-07-18 at 10:45 -0700, Manasi Navare wrote: > On Wed, Jul 18, 2018 at 10:19:42AM -0700, Dhinakaran Pandiyan wrote: > > > > The short pulse handler checks if channel equalization is okay and > > goes onto retrain a link if there are active MST links. This > > retraining > > path is not

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Manasi Navare
On Wed, Jul 18, 2018 at 10:19:42AM -0700, Dhinakaran Pandiyan wrote: > The short pulse handler checks if channel equalization is okay and > goes onto retrain a link if there are active MST links. This retraining > path is not meant for new MST connections, but due to a bug elsewhere, if >

[Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

2018-07-18 Thread Dhinakaran Pandiyan
The short pulse handler checks if channel equalization is okay and goes onto retrain a link if there are active MST links. This retraining path is not meant for new MST connections, but due to a bug elsewhere, if active_mst_links is < 0 the boolean check for active_mst_links passes and we proceed