Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-13 Thread Ville Syrjälä
On Mon, Oct 12, 2020 at 10:36:45PM +0300, Imre Deak wrote: > On Wed, Oct 07, 2020 at 10:22:41PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we call .hpd_irq_setup() directly just before display > > resume, and follow it with another call via intel_hpd_init() > > just aft

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-12 Thread Imre Deak
On Wed, Oct 07, 2020 at 10:22:41PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we call .hpd_irq_setup() directly just before display > resume, and follow it with another call via intel_hpd_init() > just afterwards. Assuming the hpd pins are marked as enabled > during the open-

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-08 Thread Ville Syrjälä
On Wed, Oct 07, 2020 at 06:15:47PM -0400, Lyude Paul wrote: > On Wed, 2020-10-07 at 22:22 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we call .hpd_irq_setup() directly just before display > > resume, and follow it with another call via intel_hpd_init() > > just afterward

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-07 Thread Lyude Paul
On Wed, 2020-10-07 at 22:22 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we call .hpd_irq_setup() directly just before display > resume, and follow it with another call via intel_hpd_init() > just afterwards. Assuming the hpd pins are marked as enabled > during the open-coded c

[Intel-gfx] [PATCH v2 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-07 Thread Ville Syrjala
From: Ville Syrjälä Currently we call .hpd_irq_setup() directly just before display resume, and follow it with another call via intel_hpd_init() just afterwards. Assuming the hpd pins are marked as enabled during the open-coded call these two things do exactly the same thing (ie. enable HPD inter