Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Sarvela, Tomi P
> From: Sarvela, Tomi P > > From: Ville Syrjälä > > On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote: > > > > From: Ville Syrjälä > > > > > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: >

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Sarvela, Tomi P
> From: Ville Syrjälä > On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote: > > > From: Ville Syrjälä > > > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > > > On Mon, 13 Dec 2021, Ville S

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Ville Syrjälä
On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote: > > From: Ville Syrjälä > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > > On Mon, 13 Dec 2021, Ville Syrjala > > > > wrote: > > > > >

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Sarvela, Tomi P
> From: Ville Syrjälä > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > On Mon, 13 Dec 2021, Ville Syrjala wrote: > > > > > > This one is only used in gvt, anyway. And that actually makes me wonder > > > if t

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-14 Thread Jani Nikula
On Tue, 14 Dec 2021, Ville Syrjälä wrote: > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: >> On Mon, 13 Dec 2021, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Parametrize ilk+ FBC register offsets based on the FBC instance. >> > >> > v2: More intel_ namespace (Jani) >>

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-14 Thread Ville Syrjälä
On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > On Mon, 13 Dec 2021, Ville Syrjala wrote: > > > > This one is only used in gvt, anyway. And that actually makes me wonder > > if this should be breaking the build. Doe

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-14 Thread Ville Syrjälä
On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > On Mon, 13 Dec 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Parametrize ilk+ FBC register offsets based on the FBC instance. > > > > v2: More intel_ namespace (Jani) > > > > Cc: Jani Nikula > > Signed-off-by: Ville Syrj

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-13 Thread Jani Nikula
On Mon, 13 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Parametrize ilk+ FBC register offsets based on the FBC instance. > > v2: More intel_ namespace (Jani) > > Cc: Jani Nikula > Signed-off-by: Ville Syrjälä Some questions below, apart from that, Reviewed-by: Jani Nikula > ---

[Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-13 Thread Ville Syrjala
From: Ville Syrjälä Parametrize ilk+ FBC register offsets based on the FBC instance. v2: More intel_ namespace (Jani) Cc: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 34 +--- drivers/gpu/drm/i915/display/intel_fbc.h | 6 +