Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Fix mmio vs. CS flip race on ILK+

2014-05-22 Thread sourab gupta
Reviewed the code. Everything looks good, so Reviewed-by: Sourab Gupta sourabgu...@gmail.com On Wed, May 21, 2014 at 6:09 AM, Rodrigo Vivi rodrigo.v...@gmail.comwrote: needs a small rebase but everything looks good for me so Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com On Tue, Apr 15,

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Fix mmio vs. CS flip race on ILK+

2014-05-21 Thread Daniel Vetter
On Tue, Apr 15, 2014 at 09:41:34PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Starting from ILK, mmio flips also cause a flip done interrupt to be signalled. This means if we first do a set_base and follow it immediately with the CS flip, we

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Fix mmio vs. CS flip race on ILK+

2014-05-20 Thread Rodrigo Vivi
needs a small rebase but everything looks good for me so Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com On Tue, Apr 15, 2014 at 11:41 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Starting from ILK, mmio flips also cause a flip done interrupt to

[Intel-gfx] [PATCH v2 1/5] drm/i915: Fix mmio vs. CS flip race on ILK+

2014-04-15 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Starting from ILK, mmio flips also cause a flip done interrupt to be signalled. This means if we first do a set_base and follow it immediately with the CS flip, we might mistake the flip done interrupt caused by the set_base as the flip done