Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-04 Thread Daniel Vetter
On Fri, Dec 04, 2015 at 02:12:14PM +0100, Takashi Iwai wrote: > On Fri, 04 Dec 2015 14:07:03 +0100, > Ville Syrjälä wrote: > > > > On Fri, Dec 04, 2015 at 01:54:56PM +0100, Takashi Iwai wrote: > > > On Fri, 04 Dec 2015 13:16:46 +0100, > > > Ville Syrjälä wrote: > > > > > > > > On Tue, Dec 01, 201

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-04 Thread Takashi Iwai
On Fri, 04 Dec 2015 14:07:03 +0100, Ville Syrjälä wrote: > > On Fri, Dec 04, 2015 at 01:54:56PM +0100, Takashi Iwai wrote: > > On Fri, 04 Dec 2015 13:16:46 +0100, > > Ville Syrjälä wrote: > > > > > > On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > > > > to_intel_crtc() always retu

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-04 Thread Ville Syrjälä
On Fri, Dec 04, 2015 at 01:54:56PM +0100, Takashi Iwai wrote: > On Fri, 04 Dec 2015 13:16:46 +0100, > Ville Syrjälä wrote: > > > > On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > > > to_intel_crtc() always returns a non-NULL pointer. > > > > Eh? to_intel_crtc(NULL) should return N

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-04 Thread Takashi Iwai
On Fri, 04 Dec 2015 13:16:46 +0100, Ville Syrjälä wrote: > > On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > > to_intel_crtc() always returns a non-NULL pointer. > > Eh? to_intel_crtc(NULL) should return NULL or we might have tons of > breakage on our hands. Or maybe the atomic wo

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-04 Thread Ville Syrjälä
On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > to_intel_crtc() always returns a non-NULL pointer. Eh? to_intel_crtc(NULL) should return NULL or we might have tons of breakage on our hands. Or maybe the atomic work has gotten rid of that assumption, but at least we used to depend o

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-04 Thread Daniel Vetter
On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > to_intel_crtc() always returns a non-NULL pointer. > > Signed-off-by: Takashi Iwai Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_audio.c | 4 > 1 file changed, 4 deletions(-) > > diff --g

[Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

2015-12-01 Thread Takashi Iwai
to_intel_crtc() always returns a non-NULL pointer. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_audio.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 4dccd9b003a1..0c38cc6c82ae 100644 --- a/driv