Re: [Intel-gfx] [PATCH v2 10/13] drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 04:48:39PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:26PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On SKL+ the plane WM/BUF_CFG registers are a proper part of each > > plane's register set. That means accessing them will cancel any > >

Re: [Intel-gfx] [PATCH v2 10/13] drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+

2018-11-20 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:26PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On SKL+ the plane WM/BUF_CFG registers are a proper part of each > plane's register set. That means accessing them will cancel any > pending plane update, and we would need a PLANE_SURF register write > to

[Intel-gfx] [PATCH v2 10/13] drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+

2018-11-14 Thread Ville Syrjala
From: Ville Syrjälä On SKL+ the plane WM/BUF_CFG registers are a proper part of each plane's register set. That means accessing them will cancel any pending plane update, and we would need a PLANE_SURF register write to arm the wm/ddb change as well. To avoid all the problems with that let's