Re: [Intel-gfx] [PATCH v2 10/25] drm/i915: gen2: move error capture of IER to its correct place

2014-04-24 Thread Rodrigo Vivi
Although there are more work to be done I don't see any issue or damage by putting it already to the correct place. So, feel free to use: Reviewed-by: Rodrigo Vivi On Wed, Apr 16, 2014 at 9:57 AM, Imre Deak wrote: > On Wed, 2014-04-16 at 15:22 +0300, Ville Syrjälä wrote: >> On Mon, Apr 14, 2014

Re: [Intel-gfx] [PATCH v2 10/25] drm/i915: gen2: move error capture of IER to its correct place

2014-04-16 Thread Imre Deak
On Wed, 2014-04-16 at 15:22 +0300, Ville Syrjälä wrote: > On Mon, Apr 14, 2014 at 08:24:31PM +0300, Imre Deak wrote: > > While checking the error capture path I noticed that this register is > > read twice for GEN2, so fix this and also move the read where it's done > > for other platforms. > > >

Re: [Intel-gfx] [PATCH v2 10/25] drm/i915: gen2: move error capture of IER to its correct place

2014-04-16 Thread Ville Syrjälä
On Mon, Apr 14, 2014 at 08:24:31PM +0300, Imre Deak wrote: > While checking the error capture path I noticed that this register is > read twice for GEN2, so fix this and also move the read where it's done > for other platforms. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_gpu_e

[Intel-gfx] [PATCH v2 10/25] drm/i915: gen2: move error capture of IER to its correct place

2014-04-14 Thread Imre Deak
While checking the error capture path I noticed that this register is read twice for GEN2, so fix this and also move the read where it's done for other platforms. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_gpu_error.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) dif