Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-29 Thread Manasi Navare
On Thu, Aug 23, 2018 at 01:57:46PM -0700, Rodrigo Vivi wrote: > On Thu, Aug 23, 2018 at 01:34:54PM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Wed, 2018-08-08 at 22:55 -0700, Rodrigo Vivi wrote: > > > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > > > If a eDP panel

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Rodrigo Vivi
On Thu, Aug 23, 2018 at 01:34:54PM -0700, Dhinakaran Pandiyan wrote: > > > On Wed, 2018-08-08 at 22:55 -0700, Rodrigo Vivi wrote: > > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > > If a eDP panel supports both PSR2 and VDSC, our HW cannot > > > support both at a time. Give

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Dhinakaran Pandiyan
On Wed, 2018-08-08 at 22:55 -0700, Rodrigo Vivi wrote: > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > If a eDP panel supports both PSR2 and VDSC, our HW cannot > > support both at a time. Give priority to PSR2 if a requested > > resolution can be supported without

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Rodrigo Vivi
On Thu, Aug 23, 2018 at 12:22:29PM -0700, Manasi Navare wrote: > Thanks Rodrigo for your review. Please find the answers below: > > On Wed, Aug 08, 2018 at 10:55:13PM -0700, Rodrigo Vivi wrote: > > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > > If a eDP panel supports both

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Manasi Navare
Thanks Rodrigo for your review. Please find the answers below: On Wed, Aug 08, 2018 at 10:55:13PM -0700, Rodrigo Vivi wrote: > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > If a eDP panel supports both PSR2 and VDSC, our HW cannot > > support both at a time. Give priority to

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-08 Thread Rodrigo Vivi
On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > If a eDP panel supports both PSR2 and VDSC, our HW cannot > support both at a time. Give priority to PSR2 if a requested > resolution can be supported without compression else enable > VDSC and keep PSR2 disabled. what about PSR1 on

[Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-07-31 Thread Manasi Navare
If a eDP panel supports both PSR2 and VDSC, our HW cannot support both at a time. Give priority to PSR2 if a requested resolution can be supported without compression else enable VDSC and keep PSR2 disabled. Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: Manasi Navare ---