Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

Op 03-11-15 om 14:11 schreef Ville Syrjälä: > On Tue, Nov 03, 2015 at 01:00:32PM +0100, Maarten Lankhorst wrote: >> Op 03-11-15 om 11:40 schreef Ville Syrjälä: >>> On Tue, Nov 03, 2015 at 11:06:53AM +0100, Maarten Lankhorst wrote: Op 03-11-15 om 10:09 schreef Ville Syrjälä: > On Tue, Nov

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

On Tue, Nov 17, 2015 at 02:59:35PM +0100, Maarten Lankhorst wrote: > Op 03-11-15 om 14:11 schreef Ville Syrjälä: > > On Tue, Nov 03, 2015 at 01:00:32PM +0100, Maarten Lankhorst wrote: > >> Op 03-11-15 om 11:40 schreef Ville Syrjälä: > >>> On Tue, Nov 03, 2015 at 11:06:53AM +0100, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

On Tue, Nov 03, 2015 at 08:31:53AM +0100, Maarten Lankhorst wrote: > This fixes a warning when the crtc is turned off. In that case fb > will be NULL, and crtc_clock will be 0. Because the crtc is no longer > active this is not a bug, and shouldn't trigger the WARN_ON. Mm. We want to do scaling

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

Op 03-11-15 om 10:09 schreef Ville Syrjälä: > On Tue, Nov 03, 2015 at 08:31:53AM +0100, Maarten Lankhorst wrote: >> This fixes a warning when the crtc is turned off. In that case fb >> will be NULL, and crtc_clock will be 0. Because the crtc is no longer >> active this is not a bug, and shouldn't

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

On Tue, Nov 03, 2015 at 01:00:32PM +0100, Maarten Lankhorst wrote: > Op 03-11-15 om 11:40 schreef Ville Syrjälä: > > On Tue, Nov 03, 2015 at 11:06:53AM +0100, Maarten Lankhorst wrote: > >> Op 03-11-15 om 10:09 schreef Ville Syrjälä: > >>> On Tue, Nov 03, 2015 at 08:31:53AM +0100, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

Op 03-11-15 om 11:40 schreef Ville Syrjälä: > On Tue, Nov 03, 2015 at 11:06:53AM +0100, Maarten Lankhorst wrote: >> Op 03-11-15 om 10:09 schreef Ville Syrjälä: >>> On Tue, Nov 03, 2015 at 08:31:53AM +0100, Maarten Lankhorst wrote: This fixes a warning when the crtc is turned off. In that case

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

On Tue, Nov 03, 2015 at 11:06:53AM +0100, Maarten Lankhorst wrote: > Op 03-11-15 om 10:09 schreef Ville Syrjälä: > > On Tue, Nov 03, 2015 at 08:31:53AM +0100, Maarten Lankhorst wrote: > >> This fixes a warning when the crtc is turned off. In that case fb > >> will be NULL, and crtc_clock will be

[Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

This fixes a warning when the crtc is turned off. In that case fb will be NULL, and crtc_clock will be 0. Because the crtc is no longer active this is not a bug, and shouldn't trigger the WARN_ON. Also remove handling a null crtc_state, with all transitional helpers gone this can no longer