Re: [Intel-gfx] [PATCH v2 16/17] drm/i915: Convert cdclk to global state

2020-01-27 Thread Imre Deak
On Mon, Jan 27, 2020 at 07:15:06PM +0200, Ville Syrjälä wrote: > On Mon, Jan 27, 2020 at 07:03:01PM +0200, Imre Deak wrote: > > On Tue, Jan 21, 2020 at 04:03:53PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Let's convert cdclk_state to be a proper global state. That allows >

Re: [Intel-gfx] [PATCH v2 16/17] drm/i915: Convert cdclk to global state

2020-01-27 Thread Imre Deak
On Tue, Jan 21, 2020 at 04:03:53PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's convert cdclk_state to be a proper global state. That allows > us to use the regular atomic old vs. new state accessor, hopefully > making the code less confusing. > > We do have to deal with a few mor

Re: [Intel-gfx] [PATCH v2 16/17] drm/i915: Convert cdclk to global state

2020-01-27 Thread Ville Syrjälä
On Mon, Jan 27, 2020 at 07:03:01PM +0200, Imre Deak wrote: > On Tue, Jan 21, 2020 at 04:03:53PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Let's convert cdclk_state to be a proper global state. That allows > > us to use the regular atomic old vs. new state accessor, hopefully > >

[Intel-gfx] [PATCH v2 16/17] drm/i915: Convert cdclk to global state

2020-01-21 Thread Ville Syrjala
From: Ville Syrjälä Let's convert cdclk_state to be a proper global state. That allows us to use the regular atomic old vs. new state accessor, hopefully making the code less confusing. We do have to deal with a few more error cases in case the cdclk state duplication fails. But so be it. v2: F