On 12/07/2019 00:51, Summers, Stuart wrote:
On Thu, 2019-07-11 at 16:59 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
This is generally much more readable than the previous implementation,
thanks! Some minor comments below...
Two issues in this code:
1.
fls() usage is incorrect causi
On Thu, 2019-07-11 at 16:59 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
This is generally much more readable than the previous implementation,
thanks! Some minor comments below...
>
> Two issues in this code:
>
> 1.
> fls() usage is incorrect causing off by one in subslice mask lookup,
From: Tvrtko Ursulin
Two issues in this code:
1.
fls() usage is incorrect causing off by one in subslice mask lookup,
which in other words means subslice mask of all zeroes is always used
(subslice mask of a slice which is not present, or even out of bounds
array access), rendering the checks in
