Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Rename IS_GEN to GT_RANGE

2018-11-28 Thread Lucas De Marchi
On Wed, Nov 28, 2018 at 10:02:22AM +0200, Jani Nikula wrote: > On Tue, 06 Nov 2018, Lucas De Marchi wrote: > > From: Rodrigo Vivi > > > > RANGE makes it longer, but clear. We are also going to add a check for > > the display part, so make rename to GT. > > I also still have my doubts about this

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Rename IS_GEN to GT_RANGE

2018-11-28 Thread Rodrigo Vivi
On Wed, Nov 28, 2018 at 10:02:22AM +0200, Jani Nikula wrote: > On Tue, 06 Nov 2018, Lucas De Marchi wrote: > > From: Rodrigo Vivi > > > > RANGE makes it longer, but clear. We are also going to add a check for > > the display part, so make rename to GT. > > I also still have my doubts about this

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Rename IS_GEN to GT_RANGE

2018-11-28 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-11-28 10:02:22) > On Tue, 06 Nov 2018, Lucas De Marchi wrote: > > From: Rodrigo Vivi > > > > RANGE makes it longer, but clear. We are also going to add a check for > > the display part, so make rename to GT. > > I also still have my doubts about this patch I'm afraid.

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Rename IS_GEN to GT_RANGE

2018-11-28 Thread Jani Nikula
On Tue, 06 Nov 2018, Lucas De Marchi wrote: > From: Rodrigo Vivi > > RANGE makes it longer, but clear. We are also going to add a check for > the display part, so make rename to GT. I also still have my doubts about this patch I'm afraid. I've expressed the concern before, but here goes again.

[Intel-gfx] [PATCH v2 2/7] drm/i915: Rename IS_GEN to GT_RANGE

2018-11-06 Thread Lucas De Marchi
From: Rodrigo Vivi RANGE makes it longer, but clear. We are also going to add a check for the display part, so make rename to GT. Diff generated with: sed 's/IS_GEN(/GT_GEN_RANGE(/g' drivers/gpu/drm/i915/*.{c,h} -i Cc: Tvrtko Ursulin Signed-off-by: Rodrigo Vivi Reviewed-by: Lucas De Marchi