[Intel-gfx] [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations

2014-11-18 Thread Dave Gordon
There are numerous places in the code where the driver's idea of how much space is left in a ring is updated using the driver's latest notions of the positions of 'head' and 'tail' for the ring. Among them are some that update one or both of these values before (re)doing the calculation. In particu

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations

2014-11-24 Thread Deepak S
On Wednesday 19 November 2014 01:37 AM, Dave Gordon wrote: There are numerous places in the code where the driver's idea of how much space is left in a ring is updated using the driver's latest notions of the positions of 'head' and 'tail' for the ring. Among them are some that update one or bot

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations

2014-11-24 Thread Daniel Vetter
On Tue, Nov 18, 2014 at 08:07:22PM +, Dave Gordon wrote: > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c > b/drivers/gpu/drm/i915/intel_ringbuffer.c > index ae09258..a08ae65 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -52,1

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations

2014-11-24 Thread Dave Gordon
On 24/11/14 10:04, Daniel Vetter wrote: > On Tue, Nov 18, 2014 at 08:07:22PM +, Dave Gordon wrote: >> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c >> b/drivers/gpu/drm/i915/intel_ringbuffer.c >> index ae09258..a08ae65 100644 >> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c >> +++ b/dri

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations

2014-11-25 Thread Daniel Vetter
On Mon, Nov 24, 2014 at 02:32:25PM +, Dave Gordon wrote: > On 24/11/14 10:04, Daniel Vetter wrote: > > On Tue, Nov 18, 2014 at 08:07:22PM +, Dave Gordon wrote: > >> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c > >> b/drivers/gpu/drm/i915/intel_ringbuffer.c > >> index ae09258..a08ae

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations

2014-11-25 Thread Chris Wilson
On Tue, Nov 25, 2014 at 12:41:16PM +0100, Daniel Vetter wrote: > On Mon, Nov 24, 2014 at 02:32:25PM +, Dave Gordon wrote: > > On 24/11/14 10:04, Daniel Vetter wrote: > > > On Tue, Nov 18, 2014 at 08:07:22PM +, Dave Gordon wrote: > > >> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c >