[Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-26 Thread Dhinakaran Pandiyan
Interrupts other than the one for AUX errors are required only for debug, so unmask them via debugfs when the user requests debug. User can make such a request with echo 1 > /dri/0/i915_edp_psr_debug v2: Unroll loops (Ville) Avoid resetting error mask bits. Cc: Rodrigo Vivi Cc: Ville Syrjäl

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-27 Thread Ville Syrjälä
On Mon, Mar 26, 2018 at 06:16:22PM -0700, Dhinakaran Pandiyan wrote: > Interrupts other than the one for AUX errors are required only for debug, > so unmask them via debugfs when the user requests debug. > > User can make such a request with > echo 1 > /dri/0/i915_edp_psr_debug > > v2: Unroll loo

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-27 Thread Chris Wilson
Quoting Dhinakaran Pandiyan (2018-03-27 02:16:22) > Interrupts other than the one for AUX errors are required only for debug, > so unmask them via debugfs when the user requests debug. > > User can make such a request with > echo 1 > /dri/0/i915_edp_psr_debug > > v2: Unroll loops (Ville) > Av

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-27 Thread Pandiyan, Dhinakaran
On Tue, 2018-03-27 at 13:24 +0300, Ville Syrjälä wrote: > On Mon, Mar 26, 2018 at 06:16:22PM -0700, Dhinakaran Pandiyan wrote: > > Interrupts other than the one for AUX errors are required only for debug, > > so unmask them via debugfs when the user requests debug. > > > > User can make such a req

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-27 Thread Pandiyan, Dhinakaran
On Tue, 2018-03-27 at 11:26 +0100, Chris Wilson wrote: > Quoting Dhinakaran Pandiyan (2018-03-27 02:16:22) > > Interrupts other than the one for AUX errors are required only for debug, > > so unmask them via debugfs when the user requests debug. > > > > User can make such a request with > > ech

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-28 Thread Ville Syrjälä
On Tue, Mar 27, 2018 at 06:33:11PM +, Pandiyan, Dhinakaran wrote: > On Tue, 2018-03-27 at 13:24 +0300, Ville Syrjälä wrote: > > On Mon, Mar 26, 2018 at 06:16:22PM -0700, Dhinakaran Pandiyan wrote: > > > Interrupts other than the one for AUX errors are required only for debug, > > > so unmask th

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-28 Thread Pandiyan, Dhinakaran
On Wed, 2018-03-28 at 13:28 +0300, Ville Syrjälä wrote: > On Tue, Mar 27, 2018 at 06:33:11PM +, Pandiyan, Dhinakaran wrote: > > On Tue, 2018-03-27 at 13:24 +0300, Ville Syrjälä wrote: > > > On Mon, Mar 26, 2018 at 06:16:22PM -0700, Dhinakaran Pandiyan wrote: > > > > Interrupts other than the

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/psr: Control PSR interrupts via debugfs

2018-03-28 Thread Pandiyan, Dhinakaran
On Wed, 2018-03-28 at 17:37 +, Pandiyan, Dhinakaran wrote: > > > On Wed, 2018-03-28 at 13:28 +0300, Ville Syrjälä wrote: > > On Tue, Mar 27, 2018 at 06:33:11PM +, Pandiyan, Dhinakaran wrote: > > > On Tue, 2018-03-27 at 13:24 +0300, Ville Syrjälä wrote: > > > > On Mon, Mar 26, 2018 at 0