Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-05-28 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Friday, May 26, 2023 7:18 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign > handling > > On Thu, May 25, 2023 at 08:

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-05-26 Thread Ville Syrjälä
On Thu, May 25, 2023 at 08:55:08PM +, Shankar, Uma wrote: > > > > -Original Message- > > From: dri-devel On Behalf Of > > Ville Syrjala > > Sent: Thursday, April 13, 2023 10:19 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: dri-de...@lists.freedesktop.org > > Subject: [PATCH v2

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-05-25 Thread Shankar, Uma
> -Original Message- > From: Shankar, Uma > Sent: Friday, May 26, 2023 2:25 AM > To: Ville Syrjala ; > intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: RE: [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign > handling > > > > > -Original Mes

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-05-25 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Ville > Syrjala > Sent: Thursday, April 13, 2023 10:19 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling > > From: Ville Syrjäl

[Intel-gfx] [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä The CHV CGM CSC coefficients are in s4.12 two's complement format. Fix the CTM->CGM conversion to handle that correctly instead of pretending that the hw coefficients are also in some sign-magnitude format. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel