Re: [Intel-gfx] [PATCH v2 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

2017-11-02 Thread Daniel Vetter
On Wed, Nov 01, 2017 at 10:15:58PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_plane_helper_check_state() is supposed to do things the atomic way, > so it should not be inspecting crtc->enabled. Rather we should be > looking at crtc_state->enable. Oh dear, how often are those legac

[Intel-gfx] [PATCH v2 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä drm_plane_helper_check_state() is supposed to do things the atomic way, so it should not be inspecting crtc->enabled. Rather we should be looking at crtc_state->enable. We have a slight complication due to drm_plane_helper_check_update() reusing drm_plane_helper_check_state()