Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Move LPT PCH readout code

2021-10-19 Thread Ville Syrjälä
On Tue, Oct 19, 2021 at 05:46:33AM +1000, David Airlie wrote: > On Tue, Oct 19, 2021 at 1:35 AM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Nuke the hsw_get_ddi_port_state() eyesore by putting the > > readout code into intel_pch_display.c, and calling it directly > > from hsw_crt_g

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Move LPT PCH readout code

2021-10-18 Thread David Airlie
On Tue, Oct 19, 2021 at 1:35 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > Nuke the hsw_get_ddi_port_state() eyesore by putting the > readout code into intel_pch_display.c, and calling it directly > from hsw_crt_get_config(). > > Note that the nuked TRANS_DDI_FUNC_CTL readout from > hsw_get

[Intel-gfx] [PATCH v2 4/9] drm/i915: Move LPT PCH readout code

2021-10-18 Thread Ville Syrjala
From: Ville Syrjälä Nuke the hsw_get_ddi_port_state() eyesore by putting the readout code into intel_pch_display.c, and calling it directly from hsw_crt_get_config(). Note that the nuked TRANS_DDI_FUNC_CTL readout from hsw_get_ddi_port_state() is now etirely redundant since we get called from th