Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Goel, Akash
On 12/1/2015 7:30 PM, Ville Syrjälä wrote: On Tue, Dec 01, 2015 at 01:49:10PM +, Chris Wilson wrote: On Tue, Dec 01, 2015 at 03:28:28PM +0200, Ville Syrjälä wrote: On Tue, Dec 01, 2015 at 01:09:33PM +, Chris Wilson wrote: On Tue, Dec 01, 2015 at 02:34:41PM +0200, Ville Syrjälä wrote:

Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Ville Syrjälä
On Tue, Dec 01, 2015 at 01:49:10PM +, Chris Wilson wrote: > On Tue, Dec 01, 2015 at 03:28:28PM +0200, Ville Syrjälä wrote: > > On Tue, Dec 01, 2015 at 01:09:33PM +, Chris Wilson wrote: > > > On Tue, Dec 01, 2015 at 02:34:41PM +0200, Ville Syrjälä wrote: > > > > On Mon, Nov 30, 2015 at 12:41

Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Chris Wilson
On Tue, Dec 01, 2015 at 03:28:28PM +0200, Ville Syrjälä wrote: > On Tue, Dec 01, 2015 at 01:09:33PM +, Chris Wilson wrote: > > On Tue, Dec 01, 2015 at 02:34:41PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 30, 2015 at 12:41:05PM +0530, akash.g...@intel.com wrote: > > > > @@ -3982,7 +3983,21 @

Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Ville Syrjälä
On Tue, Dec 01, 2015 at 01:09:33PM +, Chris Wilson wrote: > On Tue, Dec 01, 2015 at 02:34:41PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 30, 2015 at 12:41:05PM +0530, akash.g...@intel.com wrote: > > > @@ -3982,7 +3983,21 @@ i915_gem_object_set_to_cpu_domain(struct > > > drm_i915_gem_object *

Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Chris Wilson
On Tue, Dec 01, 2015 at 02:34:41PM +0200, Ville Syrjälä wrote: > On Mon, Nov 30, 2015 at 12:41:05PM +0530, akash.g...@intel.com wrote: > > @@ -3982,7 +3983,21 @@ i915_gem_object_set_to_cpu_domain(struct > > drm_i915_gem_object *obj, bool write) > > > > /* Flush the CPU cache if it's still in

Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Ville Syrjälä
On Mon, Nov 30, 2015 at 12:41:05PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > When the object is moved out of CPU read domain, the cachelines > are not invalidated immediately. The invalidation is deferred till > next time the object is brought back into CPU read domain. > But the

[Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-11-29 Thread akash . goel
From: Akash Goel When the object is moved out of CPU read domain, the cachelines are not invalidated immediately. The invalidation is deferred till next time the object is brought back into CPU read domain. But the invalidation is done unconditionally, i.e. even for the case where the cachelines