Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-22 Thread Zhenyu Wang
On 2018.07.19 17:20:15 +, De Marchi, Lucas wrote: > CC'ing gvt maintainers (and fixing Jani's address in CC). > > See below > > On Wed, 2018-07-18 at 13:01 +0300, Ville Syrjälä wrote: > > On Tue, Jul 17, 2018 at 03:16:53PM -0700, Lucas De Marchi wrote: > > > On Fri, Jul 13, 2018 at 9:10 AM

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-19 Thread De Marchi, Lucas
CC'ing gvt maintainers (and fixing Jani's address in CC). See below On Wed, 2018-07-18 at 13:01 +0300, Ville Syrjälä wrote: > On Tue, Jul 17, 2018 at 03:16:53PM -0700, Lucas De Marchi wrote: > > On Fri, Jul 13, 2018 at 9:10 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Jul 13, 2018 at

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-18 Thread Ville Syrjälä
On Tue, Jul 17, 2018 at 03:16:53PM -0700, Lucas De Marchi wrote: > On Fri, Jul 13, 2018 at 9:10 AM Ville Syrjälä > wrote: > > > > On Fri, Jul 13, 2018 at 08:42:11AM -0700, Lucas De Marchi wrote: > > > Instead of defining all registers twice, define just a PCH_GPIO_BASE > > > that has the same

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-17 Thread Lucas De Marchi
On Fri, Jul 13, 2018 at 9:10 AM Ville Syrjälä wrote: > > On Fri, Jul 13, 2018 at 08:42:11AM -0700, Lucas De Marchi wrote: > > Instead of defining all registers twice, define just a PCH_GPIO_BASE > > that has the same address as PCH_GPIO_A and use that to calculate all > > the others. This also

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-13 Thread Ville Syrjälä
On Fri, Jul 13, 2018 at 08:42:11AM -0700, Lucas De Marchi wrote: > Instead of defining all registers twice, define just a PCH_GPIO_BASE > that has the same address as PCH_GPIO_A and use that to calculate all > the others. This also brings VLV and !HAS_GMCH_DISPLAY in line, doing > the same thing.

[Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-13 Thread Lucas De Marchi
Instead of defining all registers twice, define just a PCH_GPIO_BASE that has the same address as PCH_GPIO_A and use that to calculate all the others. This also brings VLV and !HAS_GMCH_DISPLAY in line, doing the same thing. v2: Fix GMBUS registers to be relative to gpio base; create GPIO()