Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-16 Thread Teres Alexis, Alan Previn
just recapping offline conversation summary - we agreed on: intel_pxp_enabled(i915) intel_pxp_enabled_on_gt(pxp) (where one is wrapper over the other, the action part of the function name stays the same). ...alan On Mon, 2022-11-14 at 21:13 -0800, Alan Previn Teres Alexis wrote: > >

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-14 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-14 at 20:00 -0800, Ceraolo Spurio, Daniele wrote: > > On 10/21/2022 10:39 AM, Alan Previn wrote: > > In preparation for future MTL-PXP feature support, PXP control > > @@ -142,22 +166,21 @@ void intel_pxp_init(struct intel_pxp *pxp) > > { > > struct intel_gt *gt =

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-14 Thread Ceraolo Spurio, Daniele
On 10/21/2022 10:39 AM, Alan Previn wrote: In preparation for future MTL-PXP feature support, PXP control context should only valid on the correct gt tile. Depending on the device-info this depends on which tile owns the VEBOX and KCR. PXP is still a global feature though (despite its

[Intel-gfx] [PATCH v3 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-10-21 Thread Alan Previn
In preparation for future MTL-PXP feature support, PXP control context should only valid on the correct gt tile. Depending on the device-info this depends on which tile owns the VEBOX and KCR. PXP is still a global feature though (despite its control-context located in the owning GT structure).