[Intel-gfx] [PATCH v3 11/28] drm/i915: Add IRQ friendly request deference facility

2014-11-24 Thread John . C . Harrison
From: John Harrison The next patches in the series convert some display related seqno usage to request structure usage. However, the request dereference introduced must be done from interrupt context. As the dereference potentially involves freeing the request structure and thus calling lots of n

Re: [Intel-gfx] [PATCH v3 11/28] drm/i915: Add IRQ friendly request deference facility

2014-11-26 Thread Daniel Vetter
On Mon, Nov 24, 2014 at 06:49:33PM +, john.c.harri...@intel.com wrote: > From: John Harrison > > The next patches in the series convert some display related seqno usage to > request structure usage. However, the request dereference introduced must be > done from interrupt context. As the dere

Re: [Intel-gfx] [PATCH v3 11/28] drm/i915: Add IRQ friendly request deference facility

2014-11-26 Thread John Harrison
On 26/11/2014 09:19, Daniel Vetter wrote: On Mon, Nov 24, 2014 at 06:49:33PM +, john.c.harri...@intel.com wrote: From: John Harrison The next patches in the series convert some display related seqno usage to request structure usage. However, the request dereference introduced must be done

Re: [Intel-gfx] [PATCH v3 11/28] drm/i915: Add IRQ friendly request deference facility

2014-11-26 Thread Daniel Vetter
On Wed, Nov 26, 2014 at 1:23 PM, John Harrison wrote: >> This needs locking. It might work as-is but it's definitely too tricky to >> be worth it. > > The manipulation of the list is locked, only this test is unlocked. Do you > really need to lock when testing for empty? Nothing can be removing it