Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-25 Thread Souza, Jose
On Tue, 2018-04-24 at 17:16 -0700, Dhinakaran Pandiyan wrote: > > > On Tue, 2018-04-24 at 14:20 -0700, Rodrigo Vivi wrote: > > On Mon, Apr 23, 2018 at 05:42:40PM -0700, Souza, Jose wrote: > > > On Fri, 2018-04-20 at 15:57 -0700, Rodrigo Vivi wrote: > > > > On Fri, Apr 20, 2018 at 03:27:56PM

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-24 Thread Dhinakaran Pandiyan
On Tue, 2018-04-24 at 14:20 -0700, Rodrigo Vivi wrote: > On Mon, Apr 23, 2018 at 05:42:40PM -0700, Souza, Jose wrote: > > On Fri, 2018-04-20 at 15:57 -0700, Rodrigo Vivi wrote: > > > On Fri, Apr 20, 2018 at 03:27:56PM -0700, José Roberto de Souza > > > wrote: > > > > Any write in any display

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-24 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 05:42:40PM -0700, Souza, Jose wrote: > On Fri, 2018-04-20 at 15:57 -0700, Rodrigo Vivi wrote: > > On Fri, Apr 20, 2018 at 03:27:56PM -0700, José Roberto de Souza > > wrote: > > > Any write in any display register was causing HW to exit PSR, > > > masking it to allow more

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-23 Thread Souza, Jose
On Fri, 2018-04-20 at 15:57 -0700, Rodrigo Vivi wrote: > On Fri, Apr 20, 2018 at 03:27:56PM -0700, José Roberto de Souza > wrote: > > Any write in any display register was causing HW to exit PSR, > > masking it to allow more power savings. Writes to pipe related > > registers will still cause HW

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-20 Thread Rodrigo Vivi
On Fri, Apr 20, 2018 at 03:27:56PM -0700, José Roberto de Souza wrote: > Any write in any display register was causing HW to exit PSR, > masking it to allow more power savings. Writes to pipe related > registers will still cause HW to exit PSR. > This is already masked for PSR2. > > Bspec: 7721

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-20 Thread Rodrigo Vivi
On Fri, Apr 20, 2018 at 03:27:56PM -0700, José Roberto de Souza wrote: > Any write in any display register was causing HW to exit PSR, > masking it to allow more power savings. Writes to pipe related > registers will still cause HW to exit PSR. > This is already masked for PSR2. This seems a good

[Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Prevent PSR exit when a non-pipe related register is written

2018-04-20 Thread José Roberto de Souza
Any write in any display register was causing HW to exit PSR, masking it to allow more power savings. Writes to pipe related registers will still cause HW to exit PSR. This is already masked for PSR2. Bspec: 7721 and 8042 Cc: Rodrigo Vivi Cc: Dhinakaran Pandiyan