Re: [Intel-gfx] [PATCH v3 24/25] drm/i915: propagate the error code from runtime PM callbacks

2014-05-05 Thread Ville Syrjälä
On Wed, Apr 30, 2014 at 09:53:08PM +0300, Imre Deak wrote: On Wed, 2014-04-30 at 21:05 +0300, Ville Syrjälä wrote: On Tue, Apr 15, 2014 at 04:39:45PM +0300, Imre Deak wrote: Atm, none of the RPM callbacks can fail, but the next patch adding RPM support for VLV changes this, so prepare for

Re: [Intel-gfx] [PATCH v3 24/25] drm/i915: propagate the error code from runtime PM callbacks

2014-04-30 Thread Ville Syrjälä
On Tue, Apr 15, 2014 at 04:39:45PM +0300, Imre Deak wrote: Atm, none of the RPM callbacks can fail, but the next patch adding RPM support for VLV changes this, so prepare for it. In case one of these callbacks return error RPM will get permanently disabled until the error is explicitly

Re: [Intel-gfx] [PATCH v3 24/25] drm/i915: propagate the error code from runtime PM callbacks

2014-04-30 Thread Imre Deak
On Wed, 2014-04-30 at 21:05 +0300, Ville Syrjälä wrote: On Tue, Apr 15, 2014 at 04:39:45PM +0300, Imre Deak wrote: Atm, none of the RPM callbacks can fail, but the next patch adding RPM support for VLV changes this, so prepare for it. In case one of these callbacks return error RPM will

[Intel-gfx] [PATCH v3 24/25] drm/i915: propagate the error code from runtime PM callbacks

2014-04-15 Thread Imre Deak
Atm, none of the RPM callbacks can fail, but the next patch adding RPM support for VLV changes this, so prepare for it. In case one of these callbacks return error RPM will get permanently disabled until the error is explicitly cleared. In the future we could add support for re-enabling it, for