Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-07-01 Thread Matt Roper
On Fri, Jun 28, 2019 at 04:52:31PM -0700, Souza, Jose wrote: > On Tue, 2019-06-25 at 17:03 -0700, Matt Roper wrote: > > Although EHL added a third combo PHY, no PHY_MISC register was added > > for > > PHY C. The bspec indicates that there's no need to program the "DE > > to > > IO Comp Pwr Down" s

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-06-28 Thread Souza, Jose
On Tue, 2019-06-25 at 17:03 -0700, Matt Roper wrote: > Although EHL added a third combo PHY, no PHY_MISC register was added > for > PHY C. The bspec indicates that there's no need to program the "DE > to > IO Comp Pwr Down" setting for this PHY that we usually need to set in > PHY_MISC. > > v2: >

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-06-26 Thread Souza, Jose
On Tue, 2019-06-25 at 17:03 -0700, Matt Roper wrote: > Although EHL added a third combo PHY, no PHY_MISC register was added > for > PHY C. The bspec indicates that there's no need to program the "DE > to > IO Comp Pwr Down" setting for this PHY that we usually need to set in > PHY_MISC. > > v2: >

[Intel-gfx] [PATCH v3 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-06-25 Thread Matt Roper
Although EHL added a third combo PHY, no PHY_MISC register was added for PHY C. The bspec indicates that there's no need to program the "DE to IO Comp Pwr Down" setting for this PHY that we usually need to set in PHY_MISC. v2: - Add IS_ELKHARTLAKE() guards since future platforms that have a PHY