Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-15 Thread Jani Nikula
On Mon, 06 Jan 2020, "Manna, Animesh" wrote: > Sure Manasi, I will make intel_get_adjust_train() non-static and keep in > intel_dp_link_training.c. > Now as suggested by Jani before > (https://patchwork.freedesktop.org/patch/345823/?series=71121&rev=1#comment_640087) > other non static function

Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-06 Thread Manna, Animesh
On 04-01-2020 05:18, Manasi Navare wrote: On Thu, Jan 02, 2020 at 03:56:09PM +0530, Manna, Animesh wrote: On 02-01-2020 14:48, Jani Nikula wrote: On Mon, 30 Dec 2019, Animesh Manna wrote: vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other t

Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-03 Thread Manasi Navare
On Thu, Jan 02, 2020 at 03:56:09PM +0530, Manna, Animesh wrote: > On 02-01-2020 14:48, Jani Nikula wrote: > >On Mon, 30 Dec 2019, Animesh Manna wrote: > >>vswing/pre-emphasis adjustment calculation is needed in processing > >>of auto phy compliance request other than link training, so moved > >>th

Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-02 Thread Manna, Animesh
On 02-01-2020 14:48, Jani Nikula wrote: On Mon, 30 Dec 2019, Animesh Manna wrote: vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. I guess I'm still asking why you think this is

Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-02 Thread Jani Nikula
On Mon, 30 Dec 2019, Animesh Manna wrote: > vswing/pre-emphasis adjustment calculation is needed in processing > of auto phy compliance request other than link training, so moved > the same function in intel_dp.c. I guess I'm still asking why you think this is better located in intel_dp.c than in

[Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-30 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. No functional change. v1: initial patch. v2: - used "intel_dp" prefix in function name. (Jani) - used array notation instead pointe

[Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-23 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. No functional change. v1: initial patch. v2: - used "intel_dp" prefix in function name. (Jani) - used array notation instead pointe

[Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-23 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. No functional change. v1: initial patch. v2: - used "intel_dp" prefix in function name. (Jani) - used array notation instead pointe