Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-05-08 Thread Sharma, Shashank
We (Me and Uma) confirmed the ICL register programming sequence, by dumping the registers. The correct sequence should be: ilk_lut_12p4_udw ilk_lut_12p4_ldw We passed maximum value LUT (1.0) and saw only blue output, if programmed in opposite sequence. Programming in above mentioned

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-05-08 Thread Sharma, Shashank
On 5/7/2019 7:57 PM, Ville Syrjälä wrote: On Tue, May 07, 2019 at 07:26:44PM +0530, Shashank Sharma wrote: ICL introduces a new gamma correction mode in display engine, called multi-segmented-gamma mode. This mode allows users to program the darker region of the gamma curve with sueprfine

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 07:26:44PM +0530, Shashank Sharma wrote: > ICL introduces a new gamma correction mode in display engine, called > multi-segmented-gamma mode. This mode allows users to program the > darker region of the gamma curve with sueprfine precision. An > example use case for this is

[Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-05-07 Thread Shashank Sharma
ICL introduces a new gamma correction mode in display engine, called multi-segmented-gamma mode. This mode allows users to program the darker region of the gamma curve with sueprfine precision. An example use case for this is HDR curves (like PQ ST-2084). If we plot a gamma correction curve from