Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-11-10 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 01:47:23PM +0200, Ville Syrjälä wrote: > On Wed, Nov 02, 2022 at 11:16:48PM +0100, Peter Zijlstra wrote: > > On Wed, Nov 02, 2022 at 06:57:51PM +0200, Ville Syrjälä wrote: > > > On Thu, Oct 27, 2022 at 06:53:23PM +0200, Peter Zijlstra wrote: > > > > On Thu, Oct 27, 2022 at 0

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-11-07 Thread Ville Syrjälä
On Wed, Nov 02, 2022 at 11:16:48PM +0100, Peter Zijlstra wrote: > On Wed, Nov 02, 2022 at 06:57:51PM +0200, Ville Syrjälä wrote: > > On Thu, Oct 27, 2022 at 06:53:23PM +0200, Peter Zijlstra wrote: > > > On Thu, Oct 27, 2022 at 04:09:01PM +0300, Ville Syrjälä wrote: > > > > On Wed, Oct 26, 2022 at 0

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-11-02 Thread Peter Zijlstra
On Wed, Nov 02, 2022 at 06:57:51PM +0200, Ville Syrjälä wrote: > On Thu, Oct 27, 2022 at 06:53:23PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 27, 2022 at 04:09:01PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > > > > > > Could you please giv

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-11-02 Thread Ville Syrjälä
On Thu, Oct 27, 2022 at 06:53:23PM +0200, Peter Zijlstra wrote: > On Thu, Oct 27, 2022 at 04:09:01PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > > > > Could you please give the below a spin? > > > > Thanks. I've added this to our CI branch. I'

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-27 Thread Peter Zijlstra
On Thu, Oct 27, 2022 at 04:09:01PM +0300, Ville Syrjälä wrote: > On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > > Could you please give the below a spin? > > Thanks. I've added this to our CI branch. I'll try to keep and eye > on it in the coming days and let you know if anythi

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-27 Thread Ville Syrjälä
On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > On Wed, Oct 26, 2022 at 01:32:31PM +0300, Ville Syrjälä wrote: > > Short form looks to be this: > > <4>[ 355.437846] 1 lock held by rs:main Q:Reg/359: > > <4>[ 355.438418] #0: 88844693b758 (&rq->__lock){-.-.}-{2:2}, at: > > r

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-27 Thread Peter Zijlstra
On Thu, Oct 27, 2022 at 01:58:09PM +0800, Chen Yu wrote: > > It's a very narrow race between schedule() and task_call_func(). > > > > CPU0 CPU1 > > > > __schedule() > > rq_lock(); > > prev_state = READ_ONCE(prev->__state); > > if (...

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-26 Thread Chen Yu
On 2022-10-26 at 13:43:00 +0200, Peter Zijlstra wrote: > On Wed, Oct 26, 2022 at 01:32:31PM +0300, Ville Syrjälä wrote: > > Short form looks to be this: > > <4>[ 355.437846] 1 lock held by rs:main Q:Reg/359: > > <4>[ 355.438418] #0: 88844693b758 (&rq->__lock){-.-.}-{2:2}, at: > > raw_spin_r

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-26 Thread Peter Zijlstra
On Wed, Oct 26, 2022 at 02:12:02PM +0200, Peter Zijlstra wrote: > On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > > On Wed, Oct 26, 2022 at 01:32:31PM +0300, Ville Syrjälä wrote: > > > Short form looks to be this: > > > <4>[ 355.437846] 1 lock held by rs:main Q:Reg/359: > > > <4>

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-26 Thread Peter Zijlstra
On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > On Wed, Oct 26, 2022 at 01:32:31PM +0300, Ville Syrjälä wrote: > > Short form looks to be this: > > <4>[ 355.437846] 1 lock held by rs:main Q:Reg/359: > > <4>[ 355.438418] #0: 88844693b758 (&rq->__lock){-.-.}-{2:2}, at: > > r

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-26 Thread Peter Zijlstra
On Wed, Oct 26, 2022 at 01:32:31PM +0300, Ville Syrjälä wrote: > Short form looks to be this: > <4>[ 355.437846] 1 lock held by rs:main Q:Reg/359: > <4>[ 355.438418] #0: 88844693b758 (&rq->__lock){-.-.}-{2:2}, at: > raw_spin_rq_lock_nested+0x1b/0x30 > <4>[ 355.438432] rs:main Q:Reg/359 hol

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-26 Thread Ville Syrjälä
On Tue, Oct 25, 2022 at 12:49:13PM +0200, Peter Zijlstra wrote: > On Tue, Oct 25, 2022 at 07:52:07AM +0300, Ville Syrjälä wrote: > > On Fri, Oct 21, 2022 at 08:22:41PM +0300, Ville Syrjälä wrote: > > > On Mon, Aug 22, 2022 at 01:18:22PM +0200, Peter Zijlstra wrote: > > > > +#ifdef CONFIG_LOCKDEP >

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-25 Thread Peter Zijlstra
On Tue, Oct 25, 2022 at 07:52:07AM +0300, Ville Syrjälä wrote: > On Fri, Oct 21, 2022 at 08:22:41PM +0300, Ville Syrjälä wrote: > > On Mon, Aug 22, 2022 at 01:18:22PM +0200, Peter Zijlstra wrote: > > > +#ifdef CONFIG_LOCKDEP > > > + /* > > > + * It's dangerous to freeze with locks held; there be d

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-24 Thread Ville Syrjälä
On Fri, Oct 21, 2022 at 08:22:41PM +0300, Ville Syrjälä wrote: > On Mon, Aug 22, 2022 at 01:18:22PM +0200, Peter Zijlstra wrote: > > +#ifdef CONFIG_LOCKDEP > > + /* > > +* It's dangerous to freeze with locks held; there be dragons there. > > +*/ > > + if (!(state & __TASK_FREEZABLE_UNSA

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-21 Thread Ville Syrjälä
On Mon, Aug 22, 2022 at 01:18:22PM +0200, Peter Zijlstra wrote: > +#ifdef CONFIG_LOCKDEP > + /* > + * It's dangerous to freeze with locks held; there be dragons there. > + */ > + if (!(state & __TASK_FREEZABLE_UNSAFE)) > + WARN_ON_ONCE(debug_locks && p->lockdep_depth);