[Intel-gfx] [PATCH v3 6/8] drm/i915/guc: Combine enable_guc_loading|submission modparams

2017-12-05 Thread Michal Wajdeczko
We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need submission=1, we also need loading=1. We also need loading=1 when we want to want to load and verify the HuC. Lets combine above module parameters into one "enable_guc" modp

Re: [Intel-gfx] [PATCH v3 6/8] drm/i915/guc: Combine enable_guc_loading|submission modparams

2017-12-05 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-05 16:38:42) > -void intel_uc_sanitize_options(struct drm_i915_private *dev_priv) > +static int __get_platform_enable_guc(struct drm_i915_private *dev_priv) > { > - if (!HAS_GUC(dev_priv)) { > - if (i915_modparams.enable_guc_loading > 0 || > -

Re: [Intel-gfx] [PATCH v3 6/8] drm/i915/guc: Combine enable_guc_loading|submission modparams

2017-12-06 Thread Michal Wajdeczko
On Tue, 05 Dec 2017 23:47:21 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2017-12-05 16:38:42) -void intel_uc_sanitize_options(struct drm_i915_private *dev_priv) +static int __get_platform_enable_guc(struct drm_i915_private *dev_priv) { - if (!HAS_GUC(dev_priv)) { -

Re: [Intel-gfx] [PATCH v3 6/8] drm/i915/guc: Combine enable_guc_loading|submission modparams

2017-12-06 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-06 12:10:15) > On Tue, 05 Dec 2017 23:47:21 +0100, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2017-12-05 16:38:42) > >> -void intel_uc_sanitize_options(struct drm_i915_private *dev_priv) > >> +static int __get_platform_enable_guc(struct drm_i915_priv