Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-26 Thread Chris Wilson
On Tue, Jan 26, 2016 at 11:53:45AM +, Tvrtko Ursulin wrote: > Chris Harris has liaised with Tomi and apparently GuC firmware is > already on the lab SKLs from ~two weeks ago. > > Since the firmware is on all machines, presumably we would also want > to have CI runs without the GuC enabled to

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-26 Thread Tvrtko Ursulin
On 25/01/16 16:01, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 10:54:42AM +, Tvrtko Ursulin wrote: On 03/12/15 00:56, yu@intel.com wrote: From: Alex Dai For now, remove the spinlocks that protected the GuC's statistics block and work queue; they are only accessed

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-26 Thread Daniel Vetter
On Tue, Jan 26, 2016 at 12:08:37PM +, Chris Wilson wrote: > On Tue, Jan 26, 2016 at 11:53:45AM +, Tvrtko Ursulin wrote: > > Chris Harris has liaised with Tomi and apparently GuC firmware is > > already on the lab SKLs from ~two weeks ago. > > > > Since the firmware is on all machines,

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-26 Thread Chris Wilson
On Tue, Jan 26, 2016 at 05:54:21PM +0100, Daniel Vetter wrote: > On Tue, Jan 26, 2016 at 12:08:37PM +, Chris Wilson wrote: > > On Tue, Jan 26, 2016 at 11:53:45AM +, Tvrtko Ursulin wrote: > > > Chris Harris has liaised with Tomi and apparently GuC firmware is > > > already on the lab SKLs

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 10:54:42AM +, Tvrtko Ursulin wrote: > > On 03/12/15 00:56, yu@intel.com wrote: > > From: Alex Dai > > > > For now, remove the spinlocks that protected the GuC's > > statistics block and work queue; they are only accessed > > by code that already

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-22 Thread Tvrtko Ursulin
On 03/12/15 00:56, yu@intel.com wrote: > From: Alex Dai > > For now, remove the spinlocks that protected the GuC's > statistics block and work queue; they are only accessed > by code that already holds the global struct_mutex, and > so are redundant (until the big

[Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2015-12-02 Thread yu . dai
From: Alex Dai For now, remove the spinlocks that protected the GuC's statistics block and work queue; they are only accessed by code that already holds the global struct_mutex, and so are redundant (until the big struct_mutex rewrite!). The specific problem that the spinlocks

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2015-12-02 Thread Daniel Vetter
On Wed, Dec 02, 2015 at 04:56:29PM -0800, yu@intel.com wrote: > From: Alex Dai > > For now, remove the spinlocks that protected the GuC's > statistics block and work queue; they are only accessed > by code that already holds the global struct_mutex, and > so are redundant