Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/perf: remove generated code

2020-03-12 Thread Dan Carpenter
Hi Lionel, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-perf-remove-generated-code/20200307-024544 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add following tag

[Intel-gfx] [PATCH v4 1/3] drm/i915/perf: remove generated code

2020-03-06 Thread Lionel Landwerlin
A little bit of history : Back when i915-perf was introduced (4.13), there was no way to dynamically add new OA configurations to i915. Only the generated configs baked in at build time were allowed. It quickly became obvious that we would need to allow applications to upload their