Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-23 Thread Teres Alexis, Alan Previn
typo correction... On Tue, 2022-11-22 at 12:13 -0800, Alan Previn Teres Alexis wrote: > After a more comprehensive offline discussion with Daniele and Rodrigo, > design direction was made to go with Option2 > where we elevate pxp to a global subsystem and within it it establish a > pointer to th

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-22 Thread Rodrigo Vivi
On Tue, Nov 22, 2022 at 06:50:14PM +, Teres Alexis, Alan Previn wrote: > > > On Tue, 2022-11-22 at 12:57 -0500, Vivi, Rodrigo wrote: > > > > > [Alan:snip] > > > As I had told I don't have a strong preference, as long as it keep clean > > and without these many helpers of something "on_gt".

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-22 Thread Teres Alexis, Alan Previn
After a more comprehensive offline discussion with Daniele and Rodrigo, design direction was made to go with Option2 where we elevate pxp to a global subsystem and within it it establish a pointer to the correct gt for pxp-controls. This also reflects the current HW architectures where the PXP fe

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-22 Thread Teres Alexis, Alan Previn
On Tue, 2022-11-22 at 12:57 -0500, Vivi, Rodrigo wrote: > > [Alan:snip] > As I had told I don't have a strong preference, as long as it keep clean > and without these many helpers of something "on_gt"... > > If this stays inside the gt, just make sure that you call for all the gts, > but then

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-22 Thread Rodrigo Vivi
On Mon, Nov 21, 2022 at 05:51:36PM +, Teres Alexis, Alan Previn wrote: > > > On Mon, 2022-11-21 at 14:06 +, Vivi, Rodrigo wrote: > > On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > > > > > > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > > > On Thu, 2022-11-17 at 11

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 14:06 +, Vivi, Rodrigo wrote: > On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > > > > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Pr

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > > > > In preparation for future MTL-PXP feature support

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Teres Alexis, Alan Previn
Thank you Jani - this was clearly my mistake (apologies to Daniele/Rodrigo) - didn't realize we had this documented. I will go through that first. ...alan On Mon, 2022-11-21 at 14:12 +0200, Jani Nikula wrote: > On Mon, 21 Nov 2022, Tvrtko Ursulin wrote: > > On 17/11/2022 22:34, Teres Alexis, Al

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Vivi, Rodrigo
On Mon, 2022-11-21 at 11:39 +, Tvrtko Ursulin wrote: > > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > > > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > > > > In preparation for future MTL-PXP feature suppor

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Jani Nikula
On Mon, 21 Nov 2022, Tvrtko Ursulin wrote: > On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: >> On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: >>> On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: In preparation for future MTL-PXP feature support, PXP control co

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-21 Thread Tvrtko Ursulin
On 17/11/2022 22:34, Teres Alexis, Alan Previn wrote: On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: In preparation for future MTL-PXP feature support, PXP control context should only valid on the correct gt tile. Depending

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-17 Thread Teres Alexis, Alan Previn
On Thu, 2022-11-17 at 11:02 -0500, Vivi, Rodrigo wrote: > On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > > In preparation for future MTL-PXP feature support, PXP control > > context should only valid on the correct gt tile. Depending on the > > device-info this depends on which ti

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-17 Thread Rodrigo Vivi
On Wed, Nov 16, 2022 at 04:30:13PM -0800, Alan Previn wrote: > In preparation for future MTL-PXP feature support, PXP control > context should only valid on the correct gt tile. Depending on the > device-info this depends on which tile owns the VEBOX and KCR. > PXP is still a global feature though

[Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-16 Thread Alan Previn
In preparation for future MTL-PXP feature support, PXP control context should only valid on the correct gt tile. Depending on the device-info this depends on which tile owns the VEBOX and KCR. PXP is still a global feature though (despite its control-context located in the owning GT structure). Add