Re: [Intel-gfx] [PATCH v4 1/6] drm/i915: tidy up initialisation failure paths (legacy)

2016-02-11 Thread Chris Wilson
On Mon, Feb 01, 2016 at 09:38:02AM +, Dave Gordon wrote: > On 30/01/16 10:50, Chris Wilson wrote: > >On Fri, Jan 29, 2016 at 07:19:26PM +, Dave Gordon wrote: > >>1. Fix intel_cleanup_ring_buffer() to handle the error cleanup > >>case where the ringbuffer has been allocated but map-and-p

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915: tidy up initialisation failure paths (legacy)

2016-02-01 Thread Dave Gordon
On 30/01/16 10:50, Chris Wilson wrote: On Fri, Jan 29, 2016 at 07:19:26PM +, Dave Gordon wrote: 1. Fix intel_cleanup_ring_buffer() to handle the error cleanup case where the ringbuffer has been allocated but map-and-pin failed. Unpin it iff it's previously been mapped-and-pinned. 2.

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915: tidy up initialisation failure paths (legacy)

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:26PM +, Dave Gordon wrote: > 1. Fix intel_cleanup_ring_buffer() to handle the error cleanup >case where the ringbuffer has been allocated but map-and-pin >failed. Unpin it iff it's previously been mapped-and-pinned. > > 2. Fix the error path in intel_init_

[Intel-gfx] [PATCH v4 1/6] drm/i915: tidy up initialisation failure paths (legacy)

2016-01-29 Thread Dave Gordon
1. Fix intel_cleanup_ring_buffer() to handle the error cleanup case where the ringbuffer has been allocated but map-and-pin failed. Unpin it iff it's previously been mapped-and-pinned. 2. Fix the error path in intel_init_ring_buffer(), which already called intel_destroy_ringbuffer_obj(),