Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-02-15 Thread Dave Gordon
On 11/02/16 13:36, Chris Wilson wrote: On Sat, Jan 30, 2016 at 11:17:07AM +, Chris Wilson wrote: On Fri, Jan 29, 2016 at 07:19:31PM +, Dave Gordon wrote: From: Nick Hoath Swap the order of context & engine cleanup, so that contexts are cleaned up first, and *then* engines. This is a m

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-02-15 Thread Dave Gordon
On 11/02/16 15:02, Mika Kuoppala wrote: Chris Wilson writes: On Sat, Jan 30, 2016 at 11:17:07AM +, Chris Wilson wrote: On Fri, Jan 29, 2016 at 07:19:31PM +, Dave Gordon wrote: From: Nick Hoath Swap the order of context & engine cleanup, so that contexts are cleaned up first, and *t

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-02-11 Thread Mika Kuoppala
Chris Wilson writes: > On Sat, Jan 30, 2016 at 11:17:07AM +, Chris Wilson wrote: >> On Fri, Jan 29, 2016 at 07:19:31PM +, Dave Gordon wrote: >> > From: Nick Hoath >> > >> > Swap the order of context & engine cleanup, so that contexts are cleaned >> > up first, and *then* engines. This i

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-02-11 Thread Chris Wilson
On Sat, Jan 30, 2016 at 11:17:07AM +, Chris Wilson wrote: > On Fri, Jan 29, 2016 at 07:19:31PM +, Dave Gordon wrote: > > From: Nick Hoath > > > > Swap the order of context & engine cleanup, so that contexts are cleaned > > up first, and *then* engines. This is a more sensible order anyway

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:31PM +, Dave Gordon wrote: > From: Nick Hoath > > Swap the order of context & engine cleanup, so that contexts are cleaned > up first, and *then* engines. This is a more sensible order anyway, but > in particular has become necessary since the 'intel_ring_initial

[Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-01-29 Thread Dave Gordon
From: Nick Hoath Swap the order of context & engine cleanup, so that contexts are cleaned up first, and *then* engines. This is a more sensible order anyway, but in particular has become necessary since the 'intel_ring_initialized() must be simple and inline' patch, which now uses ring->dev as an