[Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Umesh Nerlige Ramappa
From: Tvrtko Ursulin Having it as u64 was a confusing (but harmless) mistake. Also add some asserts to make sure the internal field does not overflow in the future. v2: Fix WARN_ON firing for INTERRUPT event (Umesh) Signed-off-by: Tvrtko Ursulin Signed-off-by: Umesh Nerlige Ramappa Cc: Ashut

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Dixit, Ashutosh
On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh/Tvrtko, Mostly repeating comments/questions made on the previous patch below. > From: Tvrtko Ursulin > > Having it as u64 was a confusing (but harmless) mistake. > > Also add some asserts to make sure the internal field

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Umesh Nerlige Ramappa
On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote: On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh/Tvrtko, Mostly repeating comments/questions made on the previous patch below. From: Tvrtko Ursulin Having it as u64 was a confusing (but harmless) mi

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-17 Thread Tvrtko Ursulin
On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote: On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh/Tvrtko, Mostly repeating comments/questions made on the previous patch below. First of all thanks

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-17 Thread Dixit, Ashutosh
On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote: > > > On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: > > On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote: > >> On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote: > >>> > >> > >> Hi Umesh/Tvrtko, > >> > >> Mos

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-17 Thread Umesh Nerlige Ramappa
On Wed, May 17, 2023 at 09:25:03AM -0700, Dixit, Ashutosh wrote: On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote: On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: > On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote: >> On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige R

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-17 Thread Dixit, Ashutosh
On Wed, 17 May 2023 13:15:14 -0700, Umesh Nerlige Ramappa wrote: > > Leaving it as is. @Ashutosh, okay to use your R-b without any changes to > this patch? Yes. Reviewed-by: Ashutosh Dixit

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-18 Thread Tvrtko Ursulin
On 17/05/2023 17:25, Dixit, Ashutosh wrote: On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote: On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote: On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote: Hi U

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-18 Thread Dixit, Ashutosh
On Thu, 18 May 2023 02:07:55 -0700, Tvrtko Ursulin wrote: > > On 17/05/2023 17:25, Dixit, Ashutosh wrote: > > On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote: > >> > >> > >> On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: > >>> On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wr