[Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-21 Thread Shashank Sharma
HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB - YCBCR 444 - YCBCR 422 - YCBCR 420 This patch adds a drm property "hdmi_output_format", using which, a user can specify its preference, f

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-22 Thread Daniel Vetter
On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: > HDMI displays can support various output types, based on > the color space and subsampling type. The possible > outputs from a HDMI 2.0 monitor could be: > - RGB > - YCBCR 444 > - YCBCR 422 > - YCBCR 420 > > This patch adds a d

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-22 Thread Sharma, Shashank
Thanks for the review, Daniel. My comments inline. Regards Shashank On 6/22/2017 12:44 PM, Daniel Vetter wrote: On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs f

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-23 Thread Daniel Vetter
On Thu, Jun 22, 2017 at 10:33 AM, Sharma, Shashank wrote: >> - The property values should be limited to what the driver can support, I >>guess that would mean limiting the available ycbcr modes? Or does all >>our hw support all the modes, including 420 (on the sink side)? > > This property

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-23 Thread Sharma, Shashank
Regards Shashank On 6/23/2017 2:50 PM, Daniel Vetter wrote: On Thu, Jun 22, 2017 at 10:33 AM, Sharma, Shashank wrote: - The property values should be limited to what the driver can support, I guess that would mean limiting the available ycbcr modes? Or does all our hw support all the

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-23 Thread Daniel Vetter
On Fri, Jun 23, 2017 at 03:35:30PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 6/23/2017 2:50 PM, Daniel Vetter wrote: > > On Thu, Jun 22, 2017 at 10:33 AM, Sharma, Shashank > > wrote: > > > > - The property values should be limited to what the driver can support, > > > > I

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-27 Thread Ville Syrjälä
On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: > HDMI displays can support various output types, based on > the color space and subsampling type. The possible > outputs from a HDMI 2.0 monitor could be: > - RGB > - YCBCR 444 > - YCBCR 422 > - YCBCR 420 > > This patch adds a d

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-29 Thread Sharma, Shashank
Regards Shashank On 6/27/2017 5:44 PM, Ville Syrjälä wrote: On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB - YCBCR