Re: [Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

2018-07-23 Thread Rodrigo Vivi
On Fri, Jul 20, 2018 at 01:15:59PM -0700, Nathan Ciobanu wrote: > Limit the link training clock recovery loop to 10 attempts at > LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2 and 80 attempts for > pre-DP 1.4 (4 voltage levels x 4 preemphasis levels x > x 5 identical voltages tries). Some faulty

Re: [Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

2018-07-23 Thread Marc Herbert
Compliance aside I had a really hard time understanding the gap between 80 and 10. I mean if up to 80 tries might be needed pre-1.4, then how come 1.4 is supposed to succeed in less than 10? Confusing. After asking Nathan and DK (thx) I suggest rephrasing the comment below with something like

Re: [Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

2018-07-20 Thread Nathan Ciobanu
On Fri, Jul 20, 2018 at 01:28:44PM -0700, Rodrigo Vivi wrote: > On Fri, Jul 20, 2018 at 01:15:59PM -0700, Nathan Ciobanu wrote: > > Limit the link training clock recovery loop to 10 attempts at > > LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2 and 80 attempts for > > pre-DP 1.4 (4 voltage levels

Re: [Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

2018-07-20 Thread Rodrigo Vivi
On Fri, Jul 20, 2018 at 01:15:59PM -0700, Nathan Ciobanu wrote: > Limit the link training clock recovery loop to 10 attempts at > LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2 and 80 attempts for > pre-DP 1.4 (4 voltage levels x 4 preemphasis levels x > x 5 identical voltages tries). Some faulty

[Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

2018-07-20 Thread Nathan Ciobanu
Limit the link training clock recovery loop to 10 attempts at LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2 and 80 attempts for pre-DP 1.4 (4 voltage levels x 4 preemphasis levels x x 5 identical voltages tries). Some faulty USB-C MST hubs can cause us to get stuck in this loop indefinitely