Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-09 07:47:04) > On 01/07/2019 18:09, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-07-01 12:34:29) > >> + if (metrics_set == 1) { > >> + oa_config = &i915->perf.oa.test_config; > >> + } else { > >> + oa_config = idr

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:29) > Here we introduce a mechanism by which the execbuf part of the i915 > driver will be able to request that a batch buffer containing the > programming for a particular OA config be created. > > We'll execute these OA configuration buffers right befo

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-08 Thread Lionel Landwerlin
On 01/07/2019 18:09, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:29) struct i915_oa_config { + struct drm_i915_private *i915; + char uuid[UUID_STRING_LEN + 1]; int id; @@ -1110,6 +1112,10 @@ struct i915_oa_config { struct attribute *attr

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:29) > struct i915_oa_config { > + struct drm_i915_private *i915; > + > char uuid[UUID_STRING_LEN + 1]; > int id; > > @@ -1110,6 +1112,10 @@ struct i915_oa_config { > struct attribute *attrs[2]; > struct device_attr

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:06, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:29) @@ -2535,9 +2635,21 @@ static int i915_perf_release(struct inode *inode, struct file *file) { struct i915_perf_stream *stream = file->private_data; struct drm_i915_private *dev_priv = st

Re: [Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:29) > @@ -2535,9 +2635,21 @@ static int i915_perf_release(struct inode *inode, > struct file *file) > { > struct i915_perf_stream *stream = file->private_data; > struct drm_i915_private *dev_priv = stream->dev_priv; > + struct i915

[Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-01 Thread Lionel Landwerlin
Here we introduce a mechanism by which the execbuf part of the i915 driver will be able to request that a batch buffer containing the programming for a particular OA config be created. We'll execute these OA configuration buffers right before executing a set of userspace commands so that a particu