Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-16 Thread Lionel Landwerlin
On 15/07/2019 14:30, Koenig, Christian wrote: Hi Lionel, sorry for the delayed response, I'm just back from vacation. Am 03.07.19 um 11:17 schrieb Lionel Landwerlin: On 03/07/2019 11:56, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:33) +   syncobj = drm_syncobj

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-15 Thread Koenig, Christian
Hi Lionel, sorry for the delayed response, I'm just back from vacation. Am 03.07.19 um 11:17 schrieb Lionel Landwerlin: > On 03/07/2019 11:56, Chris Wilson wrote: >> Quoting Lionel Landwerlin (2019-07-01 12:34:33) >>> +   syncobj = drm_syncobj_find(eb->file, >>> user_fence.handle); >

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-03 Thread Lionel Landwerlin
On 03/07/2019 11:56, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:33) + syncobj = drm_syncobj_find(eb->file, user_fence.handle); + if (!syncobj) { + DRM_DEBUG("Invalid syncobj handle provided\n"); + err =

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-03 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:33) > + syncobj = drm_syncobj_find(eb->file, user_fence.handle); > + if (!syncobj) { > + DRM_DEBUG("Invalid syncobj handle provided\n"); > + err = -EINVAL; > + g

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:18, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:33) + /* +* For timeline syncobjs we need to preallocate chains for +* later signaling. +*/ + if (point != 0 && user_fence.flags & I915

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:33) > + /* > +* For timeline syncobjs we need to preallocate chains for > +* later signaling. > +*/ > + if (point != 0 && user_fence.flags & I915_EXEC_FENCE_SIGNAL) { > +

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:13, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:33) struct i915_execbuffer { struct drm_i915_private *i915; /** i915 backpointer */ struct drm_file *file; /** per-file lookup tables and limits */ @@ -275,6 +282,7 @@ struct i915_execbuffer

Re: [Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:33) > struct i915_execbuffer { > struct drm_i915_private *i915; /** i915 backpointer */ > struct drm_file *file; /** per-file lookup tables and limits */ > @@ -275,6 +282,7 @@ struct i915_execbuffer { > > struct { >

[Intel-gfx] [PATCH v6 07/11] drm/i915: add syncobj timeline support

2019-07-01 Thread Lionel Landwerlin
Introduces a new parameters to execbuf so that we can specify syncobj handles as well as timeline points. v2: Reuse i915_user_extension_fn v3: Check that the chained extension is only present once (Chris) v4: Check that dma_fence_chain_find_seqno returns a non NULL fence (Lionel) Signed-off-by: