Re: [Intel-gfx] [PATCH v6 10/11] drm/i915/perf: execute OA configuration from command stream

2019-07-01 Thread Lionel Landwerlin
On 01/07/2019 16:32, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:36) @@ -1860,23 +1893,55 @@ static int alloc_noa_wait(struct drm_i915_private *i915) return ret; } -static void config_oa_regs(struct drm_i915_private *dev_priv, - const s

Re: [Intel-gfx] [PATCH v6 10/11] drm/i915/perf: execute OA configuration from command stream

2019-07-01 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-07-01 12:34:36) > @@ -1860,23 +1893,55 @@ static int alloc_noa_wait(struct drm_i915_private > *i915) > return ret; > } > > -static void config_oa_regs(struct drm_i915_private *dev_priv, > - const struct i915_oa_reg *regs, > -

[Intel-gfx] [PATCH v6 10/11] drm/i915/perf: execute OA configuration from command stream

2019-07-01 Thread Lionel Landwerlin
We haven't run into issues with programming the global OA/NOA registers configuration from CPU so far, but HW engineers actually recommend doing this from the command streamer. Since we have a command buffer prepared for the execbuffer side of things, we can reuse that approach here too. This als