Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Matthew Auld
On 25 April 2017 at 18:10, Lionel Landwerlin wrote: > On 25/04/17 09:42, Matthew Auld wrote: >> >> On 24 April 2017 at 19:49, Lionel Landwerlin >> wrote: >>> >>> From: Robert Bragg >>> >>> Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all >>> share (more-or-less) the same OA

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
On 25/04/17 09:42, Matthew Auld wrote: On 24 April 2017 at 19:49, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW confi

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Matthew Auld
On 24 April 2017 at 19:49, Lionel Landwerlin wrote: > From: Robert Bragg > > Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all > share (more-or-less) the same OA unit design. > > Of particular note in comparison to Haswell: some OA unit HW config > state has become per-context

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
Hey Matt, This commit had your reviewed-by on v4, are you still okay with it? Thanks! - Lionel On 24/04/17 11:49, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular no

[Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-24 Thread Lionel Landwerlin
From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW config state has become per-context state and as a consequence it is somewhat more complicated to ma