Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-12-20 Thread Tvrtko Ursulin
On 26/11/2019 04:51, Ankit Navik wrote: High resolution timer is used for predictive governor to control eu/slice/subslice based on workloads. param is provided to enable/disable/update timer configuration V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private struc

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-28 Thread Jani Nikula
Cc: Joonas On Tue, 26 Nov 2019, Ankit Navik wrote: > High resolution timer is used for predictive governor to control > eu/slice/subslice based on workloads. > > param is provided to enable/disable/update timer configuration > > V2: > * Fix code style. > * Move predictive_load_timer into a drm

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-28 Thread Tvrtko Ursulin
On 26/11/2019 13:16, Tvrtko Ursulin wrote: On 26/11/2019 11:31, Tvrtko Ursulin wrote: On 26/11/2019 11:09, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-26 10:51:22) You mentioned you did some experiment where you did something on context pinning and that it did not work so well. I do

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-27 Thread Navik, Ankit P
> On 26/11/2019 04:21, Tvrtko Ursulin wrote: > > On 26/11/2019 04:51, Ankit Navik wrote: > > High resolution timer is used for predictive governor to control > > eu/slice/subslice based on workloads. > > > > param is provided to enable/disable/update timer configuration > > > > V2: > > * Fix cod

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-27 Thread Navik, Ankit P
Hi Chris, Thank you for your feedback. > On 26/11/2019 10:52, Charis Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-26 10:51:22) > > You mentioned you did some experiment where you did something on > > context pinning and that it did not work so well. I don't know what > > that was though. I

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-26 Thread Tvrtko Ursulin
On 26/11/2019 13:21, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-26 11:31:14) On 26/11/2019 11:09, Chris Wilson wrote: Also given Tvrtko's stats, this could all be done from userspace with an extended CONTEXT_PARAM_SSEU, so why would we not do it that way? You mean patching and reco

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-26 11:31:14) > > On 26/11/2019 11:09, Chris Wilson wrote: > > Also given Tvrtko's stats, this could all be done from userspace with an > > extended CONTEXT_PARAM_SSEU, so why would we not do it that way? > > You mean patching and recompiling userspace? I don't thin

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-26 Thread Tvrtko Ursulin
On 26/11/2019 11:31, Tvrtko Ursulin wrote: On 26/11/2019 11:09, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-26 10:51:22) You mentioned you did some experiment where you did something on context pinning and that it did not work so well. I don't know what that was though. I don't think t

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-26 Thread Tvrtko Ursulin
On 26/11/2019 11:09, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-26 10:51:22) You mentioned you did some experiment where you did something on context pinning and that it did not work so well. I don't know what that was though. I don't think that was ever posted? What I am thinking is

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-26 10:51:22) > You mentioned you did some experiment where you did something on context > pinning and that it did not work so well. I don't know what that was > though. I don't think that was ever posted? > > What I am thinking is this: You drop the timer altogeth

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-26 Thread Tvrtko Ursulin
On 26/11/2019 04:51, Ankit Navik wrote: High resolution timer is used for predictive governor to control eu/slice/subslice based on workloads. param is provided to enable/disable/update timer configuration V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private struc

[Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-25 Thread Ankit Navik
High resolution timer is used for predictive governor to control eu/slice/subslice based on workloads. param is provided to enable/disable/update timer configuration V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private structure. * Make generic function to set optimum

[Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-25 Thread Ankit Navik
High resolution timer is used for predictive governor to control eu/slice/subslice based on workloads. param is provided to enable/disable/update timer configuration V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private structure. * Make generic function to set optimum

[Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-25 Thread Ankit Navik
High resolution timer is used for predictive governor to control eu/slice/subslice based on workloads. param is provided to enable/disable/update timer configuration V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private structure. * Make generic function to set optimum