Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-09 Thread Hans de Goede
Hi, On 08-01-19 18:33, Andy Shevchenko wrote: On Tue, Jan 08, 2019 at 04:35:45PM +0100, Hans de Goede wrote: Hi, On 08-01-19 15:51, Andy Shevchenko wrote: On Tue, Jan 08, 2019 at 02:45:39PM +0100, Hans de Goede wrote: On 07-01-19 16:46, Andy Shevchenko wrote: On Mon, Jan 07, 2019 at 12:15:5

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-08 Thread Andy Shevchenko
On Tue, Jan 08, 2019 at 04:35:45PM +0100, Hans de Goede wrote: > Hi, > > On 08-01-19 15:51, Andy Shevchenko wrote: > > On Tue, Jan 08, 2019 at 02:45:39PM +0100, Hans de Goede wrote: > > > On 07-01-19 16:46, Andy Shevchenko wrote: > > > > On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrot

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-08 Thread Hans de Goede
Hi, On 08-01-19 15:51, Andy Shevchenko wrote: On Tue, Jan 08, 2019 at 02:45:39PM +0100, Hans de Goede wrote: On 07-01-19 16:46, Andy Shevchenko wrote: On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: + } else if (d->pmic_i2c_address) { + if (i2c_address ==

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-08 Thread Andy Shevchenko
On Tue, Jan 08, 2019 at 02:45:39PM +0100, Hans de Goede wrote: > On 07-01-19 16:46, Andy Shevchenko wrote: > > On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: > > > + } else if (d->pmic_i2c_address) { > > > + if (i2c_address == d->pmic_i2c_address) { > > > +

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-08 Thread Hans de Goede
Hi, On 07-01-19 16:46, Andy Shevchenko wrote: On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: Most PMIC-s use only a single i2c-address, so after verifying the i2c-address matches, we can simply pass the call to regmap_update_bits. This commit adds support for this and hooks thi

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-07 Thread Andy Shevchenko
On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: > Most PMIC-s use only a single i2c-address, so after verifying the > i2c-address matches, we can simply pass the call to regmap_update_bits. > > This commit adds support for this and hooks this up for the xpower AXP288 > PMIC by setti

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-07 Thread Ville Syrjälä
On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: > Most PMIC-s use only a single i2c-address, so after verifying the > i2c-address matches, we can simply pass the call to regmap_update_bits. > > This commit adds support for this and hooks this up for the xpower AXP288 > PMIC by setti

[Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-07 Thread Hans de Goede
Most PMIC-s use only a single i2c-address, so after verifying the i2c-address matches, we can simply pass the call to regmap_update_bits. This commit adds support for this and hooks this up for the xpower AXP288 PMIC by setting the new pmic_i2c_address field. This fixes the following errors on di