Re: [Intel-gfx] [PATCH v6 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-07-27 13:03:14) > On Fri, 27 Jul 2018 12:29:15 +0200, Chris Wilson > wrote: > > > Quoting Jakub Bartmiński (2018-07-27 09:53:47) > >> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > >> b/drivers/gpu/drm/i915/i915_gem_gtt.c > >> index d0acef299b9c..8ac5214b364

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Michal Wajdeczko
On Fri, 27 Jul 2018 12:29:15 +0200, Chris Wilson wrote: Quoting Jakub Bartmiński (2018-07-27 09:53:47) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index d0acef299b9c..8ac5214b3648 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Chris Wilson
Quoting Jakub Bartmiński (2018-07-27 09:53:47) > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index d0acef299b9c..8ac5214b3648 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -2917,6 +2917,14 @@ int i

[Intel-gfx] [PATCH v6 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Jakub Bartmiński
Removing the pin bias from GuC allows us to not check for GuC every time we pin a context, which fixes the assertion error on unresolved GuC platform default in mock contexts selftest. It also seems that we were using uninitialized WOPCM variables when setting the GuC pin bias. The pin bias has to