Re: [Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

2020-04-16 Thread Maxime Ripard
Hi, On Thu, Apr 16, 2020 at 08:49:42AM -0400, Rodrigo Siqueira wrote: > First of all, thank you a lot for your review and for testing this > patchset. I'm going to prepare a new version trying to address all > issues highlight by you, Petri, and Simon (I'm already working in a new > version). Tha

Re: [Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

2020-04-16 Thread Rodrigo Siqueira
Hi Maxime, First of all, thank you a lot for your review and for testing this patchset. I'm going to prepare a new version trying to address all issues highlight by you, Petri, and Simon (I'm already working in a new version). Just a note, I run this test on top of VKMS in a virtual machine (x86)

Re: [Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

2020-04-15 Thread Maxime Ripard
Hi Rodrigo, I gave your (and Brian's) patches on a RPi, and there's a couple of things that need to be fixed. On Mon, Oct 21, 2019 at 10:00:00PM -0300, Brian Starkey wrote: > To use writeback buffers as a CRC source, we need to be able to hash > them. Implement a simple FVA-1a hashing routine for

[Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

2019-10-21 Thread Brian Starkey
To use writeback buffers as a CRC source, we need to be able to hash them. Implement a simple FVA-1a hashing routine for this purpose. Doing a bytewise hash on the framebuffer directly can be very slow if the memory is noncached. By making a copy of each line in the FB first (which can take advant