[Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-12 Thread Ramalingam C
Defining the mei-i915 interface functions and initialization of the interface. v2: Adjust to the new interface changes. [Tomas] Added further debug logs for the failures at MEI i/f. port in hdcp_port data is equipped to handle -ve values. v3: mei comp is matched for global i915 comp master

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-19 Thread Daniel Vetter
On Thu, Dec 13, 2018 at 09:31:09AM +0530, Ramalingam C wrote: > Defining the mei-i915 interface functions and initialization of > the interface. > > v2: > Adjust to the new interface changes. [Tomas] > Added further debug logs for the failures at MEI i/f. > port in hdcp_port data is equipped

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-19 Thread C, Ramalingam
On 12/19/2018 7:30 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 09:31:09AM +0530, Ramalingam C wrote: Defining the mei-i915 interface functions and initialization of the interface. v2: Adjust to the new interface changes. [Tomas] Added further debug logs for the failures at MEI i/f.

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 08:45:41PM +0530, C, Ramalingam wrote: > > On 12/19/2018 7:30 PM, Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 09:31:09AM +0530, Ramalingam C wrote: > > > Defining the mei-i915 interface functions and initialization of > > > the interface. > > > > > > v2: > > >Adju

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-20 Thread C, Ramalingam
On 12/19/2018 8:51 PM, Daniel Vetter wrote: Indeed, I overlooked that. Maybe highlight it a bit more with a separate if (!CONFIG_ENABLED(MEI_HDCP)) return false; so it stick out more in the previous patch. Currently it's a bit burried. With that + the init ordering fix

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-20 Thread Daniel Vetter
On Thu, Dec 20, 2018 at 06:48:08PM +0530, C, Ramalingam wrote: > > On 12/19/2018 8:51 PM, Daniel Vetter wrote: > > Indeed, I overlooked that. Maybe highlight it a bit more with a separate > > > > if (!CONFIG_ENABLED(MEI_HDCP)) > > return false; > > > > so it stick out more in the