[Intel-gfx] [REPOST] [PATCH] drm/i915/ppgtt: Load address space after mi_set_context

2014-06-12 Thread Ben Widawsky
On GEN8 the PDPs are saved and restored with context, which means we must set them after the context switch has occurred. If we do not do this, we end up saving the new PDPs for the old context. Example of a problem LRI PDPs 1 MI_SET_CONTEXT bar LRI_PDPs 2 MI_SET_CONTEXT foo // save PDPs 2 to

Re: [Intel-gfx] [REPOST] [PATCH] drm/i915/ppgtt: Load address space after mi_set_context

2014-06-12 Thread Ville Syrjälä
On Thu, Jun 12, 2014 at 08:25:52AM -0700, Ben Widawsky wrote: On GEN8 the PDPs are saved and restored with context, which means we must set them after the context switch has occurred. If we do not do this, we end up saving the new PDPs for the old context. Example of a problem LRI PDPs 1

Re: [Intel-gfx] [REPOST] [PATCH] drm/i915/ppgtt: Load address space after mi_set_context

2014-06-12 Thread Ben Widawsky
On Thu, Jun 12, 2014 at 07:16:48PM +0300, Ville Syrjälä wrote: On Thu, Jun 12, 2014 at 08:25:52AM -0700, Ben Widawsky wrote: On GEN8 the PDPs are saved and restored with context, which means we must set them after the context switch has occurred. If we do not do this, we end up saving the

Re: [Intel-gfx] [REPOST] [PATCH] drm/i915/ppgtt: Load address space after mi_set_context

2014-06-12 Thread Ville Syrjälä
On Thu, Jun 12, 2014 at 09:55:50AM -0700, Ben Widawsky wrote: On Thu, Jun 12, 2014 at 07:16:48PM +0300, Ville Syrjälä wrote: On Thu, Jun 12, 2014 at 08:25:52AM -0700, Ben Widawsky wrote: On GEN8 the PDPs are saved and restored with context, which means we must set them after the context

Re: [Intel-gfx] [REPOST] [PATCH] drm/i915/ppgtt: Load address space after mi_set_context

2014-06-12 Thread Daniel Vetter
On Thu, Jun 12, 2014 at 09:55:50AM -0700, Ben Widawsky wrote: This is not meant for IVB/HSW. Empirically we've found it doesn't have the same behavior, as you said above. So that's definite an issue which requires a patch rev. Sounds like we might need a per-platform do_ctx_swithc function to