Re: [Intel-gfx] [RESEND 5/6] drm/i915: Remove pci private pointer after destroying the device private

2018-07-16 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-07-16 11:32:22) > On Mon, 16 Jul 2018 10:03:31 +0200, Chris Wilson > wrote: > > > On an aborted module load, we unwind and free our device private - but > > we left a dangling pointer to our privates inside the pci_device. After > > the attempted aborted unload, w

Re: [Intel-gfx] [RESEND 5/6] drm/i915: Remove pci private pointer after destroying the device private

2018-07-16 Thread Michal Wajdeczko
On Mon, 16 Jul 2018 10:03:31 +0200, Chris Wilson wrote: On an aborted module load, we unwind and free our device private - but we left a dangling pointer to our privates inside the pci_device. After the attempted aborted unload, we may still get a call to i915_pci_remove() when the module

Re: [Intel-gfx] [RESEND 5/6] drm/i915: Remove pci private pointer after destroying the device private

2018-07-16 Thread Tvrtko Ursulin
On 16/07/2018 09:03, Chris Wilson wrote: On an aborted module load, we unwind and free our device private - but we left a dangling pointer to our privates inside the pci_device. After the attempted aborted unload, we may still get a call to i915_pci_remove() when the module is removed, potential

[Intel-gfx] [RESEND 5/6] drm/i915: Remove pci private pointer after destroying the device private

2018-07-16 Thread Chris Wilson
On an aborted module load, we unwind and free our device private - but we left a dangling pointer to our privates inside the pci_device. After the attempted aborted unload, we may still get a call to i915_pci_remove() when the module is removed, potentially chasing stale data. Signed-off-by: Chris

[Intel-gfx] [RESEND 5/6] drm/i915: Remove pci private pointer after destroying the device private

2018-07-16 Thread Chris Wilson
On an aborted module load, we unwind and free our device private - but we left a dangling pointer to our privates inside the pci_device. After the attempted aborted unload, we may still get a call to i915_pci_remove() when the module is removed, potentially chasing stale data. Signed-off-by: Chris